changes to compile again with networking enabled. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JosepMaJAZ
commented
Jun 27, 2024
•
JosepMaJAZ
commented
- forced to build with standard "gnu17" , ( so, c17 to avoid K&R function declaration problems with slirp, and gnu because there are several classes that use assembly "with the asm" keyword).
- Changed socket.c to use socketclose instead of close, and tftpd to use stdio fopen/fseek/fread/fclose instead of posix open/lseek/read/close.
- fixed some more warnings
- removed chdir and do an absolute path fopen instead.
Note: All these changes about chdir, open, lseek... are about deprecated methods that are no longer available on current versions of msys2. Rather than using a compiler setting to reenable them, i've made changes to the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.