This repository was archived by the owner on Nov 3, 2021. It is now read-only.
fix: rename_elem: update name of elem before other methods that depends on it get called. #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property name of the elem is used in the rename_element method to assign the new name of the element, however, it is not updated in the moment the method is executed. We changed the order of these events in order to have the name updated in the following calls to rename_element.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property name of the elem is used in the rename_element method to
assign the new name of the element, however,
it is not updated in the moment the method
is executed.
We changed the order of these events in order to
have the name updated in the following calls to
rename_element.