This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
fix: prevent showscan online startup when door does not exist #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScanWindow.setModel() set models of its subwidgets which then try to connect to Sardana-Taurus model extensions e.g. recordDataUpdated which raises not self-explanatory AttributeError. Early recognize this situation and raise a self-explanatory RuntimeError.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanWindow.setModel()set models of its subwidgets which then tryto connect to Sardana-Taurus model extensions e.g.
recordDataUpdatedwhich raises not self-explanatory AttributeError.
Early recognize this situation and raise a self-explanatory RuntimeError.
Fixes #1674. @cmft could you test and review this one?
I asked this related question to taurus project.