More docstring cleanup and fixes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sarnold
commented
Sep 1, 2024
sarnold
commented
- cleanup some docstrings and update some readme bits
- refactoring cleanup, add type hints/ignores and fix an error
Signed-off-by: Stephen Arnold <[email protected]>
|
Hello @sarnold! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-15 02:54:08 UTC |
* mypy helped find an error, but we still need to ignore the optional munch YAML attributes * update flake8 config bits to allow one more char of line length Signed-off-by: Stephen Arnold <[email protected]>
sarnold
force-pushed
the
more-doc-bits
branch
from
8928af9
to
26d5dc7
Compare
* this commit removes support for legacy AppIndicator3 in favor of AyatanaAppIndicator3 only Signed-off-by: Stephen Arnold <[email protected]>
sarnold
force-pushed
the
more-doc-bits
branch
from
cb0c3b9
to
8bf483e
Compare
* the above import trick is correct for ``get_state_str()`` signature Signed-off-by: Stephen Arnold <[email protected]>
sarnold
force-pushed
the
more-doc-bits
branch
from
8bf483e
to
5e4f985
Compare
Signed-off-by: Stephen Arnold <[email protected]>
Signed-off-by: Stephen Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.