Android 13 permissions fix #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conditionals to check for which OS is on the device and asks for the correct permissions accordingly
…permissions update.
…ES permission with an sdk condition on it
Tested on Tab Active 3 on Android 13 Tested on Tab Active 3 on Android 12 Both working correctly.
If READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE are restricted by sdk then other plugins (specifically the @capacitor/camera multiple image gallery picker) it complains that these two legacy permissions are missing on an Android 13 device. If the restrictions are removed then all the plugins work. It doesn't affect the photo viewer.
pranjal24
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem with viewing files on Android 13 devices.
Have tested the fix on Tab Active 3s. One of them on Android 13, the other one on Android 12. Both preview files correctly.
This was tested as a plugin on an ionic capacitor app deployed to Android Studio Flamingo 2022.2.1 Patch 2.