Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
burnettk committed Feb 5, 2025
1 parent 8a91ae2 commit 6effb73
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 35 deletions.
27 changes: 10 additions & 17 deletions spiffworkflow-frontend/src/components/ProcessModelFileList.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import { Link } from 'react-router-dom';
import {
Download,
Edit,
Favorite,
TrashCan,
View,
} from '@carbon/icons-react';
import { Download, Edit, Favorite, TrashCan, View } from '@carbon/icons-react';
import {
Button,
Table,
Expand All @@ -16,10 +10,10 @@ import {
TableRow,
} from '@carbon/react';
import { Can } from '@casl/react';
import { Ability } from '@casl/ability';
import ButtonWithConfirmation from './ButtonWithConfirmation';
import ProcessModelTestRun from './ProcessModelTestRun';
import { ProcessFile } from '../interfaces';
import { Ability } from '@casl/ability';

interface ProcessModelFileListProps {
processModel: any;
Expand Down Expand Up @@ -54,7 +48,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({

const renderButtonElements = (
processModelFile: ProcessFile,
isPrimaryBpmnFile: boolean
isPrimaryBpmnFile: boolean,
) => {
const elements = [];

Expand All @@ -75,7 +69,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
data-qa={`edit-file-${processModelFile.name.replace('.', '-')}`}
href={profileModelFileEditUrl(processModelFile)}
/>
</Can>
</Can>,
);
elements.push(
<Can I="GET" a={targetUris.processModelFileCreatePath} ability={ability}>
Expand All @@ -88,11 +82,11 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
onClick={() =>
window.open(
`/${targetUris.processModelFilePath}/${processModelFile.name}`,
'_blank'
'_blank',
)
}
/>
</Can>
</Can>,
);

if (!isPrimaryBpmnFile) {
Expand All @@ -114,7 +108,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
confirmButtonLabel="Delete"
classNameForModal="modal-within-table-cell"
/>
</Can>
</Can>,
);
}
if (processModelFile.name.match(/\.bpmn$/) && !isPrimaryBpmnFile) {
Expand All @@ -128,7 +122,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
size="lg"
onClick={() => onSetPrimaryFile(processModelFile.name)}
/>
</Can>
</Can>,
);
}
if (isTestCaseFile(processModelFile)) {
Expand All @@ -139,7 +133,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
titleText="Run BPMN unit tests defined in this file"
classNameForModal="modal-within-table-cell"
/>
</Can>
</Can>,
);
}
return elements;
Expand All @@ -157,7 +151,7 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
const isPrimaryBpmnFile =
processModelFile.name === processModel.primary_file_name;

let actionsTableCell = (
const actionsTableCell = (
<TableCell key={`${processModelFile.name}-action`} align="right">
{renderButtonElements(processModelFile, isPrimaryBpmnFile)}
</TableCell>
Expand Down Expand Up @@ -223,4 +217,3 @@ const ProcessModelFileList: React.FC<ProcessModelFileListProps> = ({
};

export default ProcessModelFileList;

Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import { useState } from 'react';
import {
FileUploader,
Modal,
} from '@carbon/react';
import { FileUploader, Modal } from '@carbon/react';

interface ProcessModelFileUploadModalProps {
showFileUploadModal: boolean;
Expand All @@ -15,17 +12,19 @@ interface FileUploadState {
filesToUpload: File[] | null;
}

const ProcessModelFileUploadModal: React.FC<ProcessModelFileUploadModalProps> = ({
const ProcessModelFileUploadModal: React.FC<
ProcessModelFileUploadModalProps
> = ({
showFileUploadModal,
processModel,
onFileUpload,

Check warning on line 20 in spiffworkflow-frontend/src/components/ProcessModelFileUploadModal.tsx

View workflow job for this annotation

GitHub Actions / tests-frontend

'onFileUpload' is defined but never used. Allowed unused args must match /^_/u
handleFileUploadCancel,
checkDuplicateFile
checkDuplicateFile,
}) => {

const [filesToUpload, setFilesToUpload] = useState<File[] | null>(null);
const [duplicateFilename, setDuplicateFilename] = useState<string>('');
const [showOverwriteConfirmationPrompt, setShowOverwriteConfirmationPrompt] = useState(false);
const [showOverwriteConfirmationPrompt, setShowOverwriteConfirmationPrompt] =
useState(false);
const [fileUploadEvent, setFileUploadEvent] = useState(null);

const handleOverwriteFileConfirm = () => {
Expand Down Expand Up @@ -126,4 +125,3 @@ const ProcessModelFileUploadModal: React.FC<ProcessModelFileUploadModalProps> =
};

export default ProcessModelFileUploadModal;

10 changes: 3 additions & 7 deletions spiffworkflow-frontend/src/components/ProcessModelReadmeArea.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import {
Button,
Column,
Grid,
} from '@carbon/react';
import { Button, Column, Grid } from '@carbon/react';
import { Can } from '@casl/react';
import { Edit } from '@carbon/icons-react';
import MarkdownDisplayForFile from './MarkdownDisplayForFile';
import { Ability } from '@casl/ability';
import MarkdownDisplayForFile from './MarkdownDisplayForFile';
import { ProcessFile } from '../interfaces';

interface ProcessModelReadmeAreaProps {
Expand All @@ -20,7 +16,7 @@ const ProcessModelReadmeArea: React.FC<ProcessModelReadmeAreaProps> = ({
readmeFile,
ability,
targetUris,
modifiedProcessModelId
modifiedProcessModelId,
}) => {
if (readmeFile) {
return (
Expand Down
4 changes: 2 additions & 2 deletions spiffworkflow-frontend/src/components/ProcessModelTabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ import {
TabPanels,
Tabs,
} from '@carbon/react';
import { Can } from '@casl/react'; // Corrected import
import { Can } from '@casl/react'; // Corrected import
import { useNavigate } from 'react-router-dom';
import { Ability } from '@casl/ability';
import ProcessInstanceListTable from './ProcessInstanceListTable';
import ProcessModelFileList from './ProcessModelFileList';
import { Ability } from '@casl/ability';
import { ProcessFile } from '../interfaces';
import ProcessModelReadmeArea from './ProcessModelReadmeArea';

Expand Down

0 comments on commit 6effb73

Please sign in to comment.