Fix execve syscall code in ropchain generator #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelamberson
force-pushed
the
fix-execve-code
branch
from
73119fc
to
93b3974
Compare
|
Are you sure, that this fix the issue? The changes shows only a change in the message |
Also use hex-formatted index in the ropchain generator to be more consistent with the x86 generator (this is not a functional change).
jakelamberson
force-pushed
the
fix-execve-code
branch
from
93b3974
to
77b88b4
Compare
|
@sashs Yes, this is right. The rop chain values are already correct. Just the message printed has the improper code. I also went ahead and also updated the indices used in the generator to be hex-formatted to be more consistent with x86 (non-functional change). You can take or leave that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Fixes a message in the x86_64 chain generator to display the correct syscall.
The original issue notes that an incorrect syscall code is displayed. I discovered that an incorrect syscall code is present in the actual chain generator for the x86 version. x86_64 is correct. This pull request fixes both generators' print statements and changes the execve code in the x86 chain generator's gadget creator to the correct 0x3b.