Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure onStdinClose only completes for non-tty streams #1665

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Apr 8, 2022

  1. Ensure onStdinClose only completes for non-tty streams

    The initial stdin commit 144cd35 inverted the TTY conditional
    b/w the io/node and io/vm implementations of onStdinClose.
    The node implementation incorrectly checked for the presence
    of TTY to complete the stream, while the vm implementation
    correctly checked for its absence. The commit that landed
    upstream c7ab426 normalized the incorrect behaviour, which
    means that sass was still not closing when stdin was closed,
    unless stdin was a TTY.
    
    Unfortunately that created a "worst of both worlds" situation
    because programs that start sass and then close unexpectedly
    will still leave zombie sass processes running in the
    background, and wrapper scripts designed to mitigate this
    exact problem will stop working because moving the process to
    the background now incorrectly causes the job to stop.
    
    This change ensures we only complete the CancelableOperation
    onStdinClose for non-tty standard input streams.
    mcrumm committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    a466228 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Add changelog entry

    mcrumm committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9db2a0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    907b969 View commit details
    Browse the repository at this point in the history