-
Notifications
You must be signed in to change notification settings - Fork 365
Implement sass --embedded
in pure JS mode
#2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8d7d4de
to
7084da7
Compare
e66df5b
to
d53fcc5
Compare
d7e6206
to
b3794eb
Compare
9112b44
to
54fabf3
Compare
257b4fd
to
ac718ee
Compare
@nex3 Any feedbacks on my last two comments above? |
@nex3 Pinging again regarding how to deal with legacy js package vs new js_introp:
So honestly I think the way js interop is handled in this PR is already at best effort. - That new code only uses js_interop and it's currently isolated from the legacy js code. Any more thoughts? Would you mind take another look at this? |
Sorry that this has taken me so long to finish reviewing, there have been a lot of things to juggle this year. I'm working on a major change (https://github.com/sass/dart-sass/tree/js-interop) to move Dart Sass to the new JS interop system. This includes creating a new package for defining typings and wrappers for the JS core library (as well as possibly pushing some changes upstream to At this point it may make sense to wait on landing this PR until that work is finished. We're already closing in on that, so it shouldn't be too much more time. |
Closes #2325.
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing