Add --built-in-only flag to module migrator #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes some built-in functions that weren't being migrated.
nex3
requested changes
Jul 17, 2024
lib/src/migrators/module.dart
Outdated
| _upstreamStylesheets.add(currentUrl); | ||
| if (migrateDependencies) visitDependency(ruleUrl, import.span); | ||
| _upstreamStylesheets.remove(currentUrl); | ||
| return; |
There was a problem hiding this comment.
Why return eagerly here? What if there are multiple imports in a single @import that all need to be traversed?
There was a problem hiding this comment.
There are a lot of special cases for builtInOnly in the module migrator. It could probably use a few more tests to exercise more of them.
nex3
reviewed
Oct 10, 2024
lib/src/migrators/module.dart
Outdated
| @@ -613,7 +630,7 @@ class _ModuleMigrationVisitor extends MigrationVisitor { | |||
| }); | |||
| } | |||
|
|
|||
| if (node.name == "get-function") { | |||
| if (node.name == "get-function" && !builtInOnly) { | |||
There was a problem hiding this comment.
What about get-function() calls for functions from built-in modules?
lib/src/migrators/module.dart
Outdated
Comment on lines
797
to
799
| _upstreamStylesheets.add(currentUrl); | ||
| if (migrateDependencies) visitDependency(ruleUrl, import.span); | ||
| _upstreamStylesheets.remove(currentUrl); |
There was a problem hiding this comment.
Since modifying _upstreamStylesheets doesn't do anything when migrateDependencies is false anyway, this makes it clearer when those lines are relevant:
Suggested change
| _upstreamStylesheets.add(currentUrl); | |
| if (migrateDependencies) visitDependency(ruleUrl, import.span); | |
| _upstreamStylesheets.remove(currentUrl); | |
| if (migrateDependencies) { | |
| _upstreamStylesheets.add(currentUrl); | |
| visitDependency(ruleUrl, import.span); | |
| _upstreamStylesheets.remove(currentUrl); | |
| } |
jathak
changed the title
nex3
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes some built-in functions that weren't being migrated.