improve logging and error handling

sassoftware · Nov 13, 2023 · 0bf4748 · 0bf4748
1 parent fcf77c5
commit 0bf4748
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 9 deletions.
diff --git a/internal/esp/client/espwsclient.go b/internal/esp/client/espwsclient.go
@@ -204,7 +204,7 @@ func (espWsClient *EspWsClient) handleBulkMessage(encodedMessages *[]string) {
 		var message messagedto.MessageDTO
 		err = json.Unmarshal(*decodedMessage, &message)
 		if err != nil {
-			log.DefaultLogger.Error(fmt.Sprintf("Cannot unmarshal message: %v", message))
+			log.DefaultLogger.Error(fmt.Sprintf("Cannot unmarshal message: %s", *decodedMessage))
 			return
 		}
 

diff --git a/pkg/plugin/plugin.go b/pkg/plugin/plugin.go
@@ -337,6 +337,22 @@ func (d *SampleDatasource) PublishStream(_ context.Context, _ *backend.PublishSt
 	}, nil
 }
 
+type callResourceResponseBody struct {
+	Error *string         `json:"error,omitempty"`
+	Data  json.RawMessage `json:"data,omitempty"`
+}
+
+func newSerializedCallResourceResponseErrorBody(errorMessage string) []byte {
+	errorResponseBody, err := json.Marshal(callResourceResponseBody{
+		Error: &errorMessage,
+	})
+	if err != nil {
+		errorResponseBody = []byte(`{error:"Internal server error"}`)
+	}
+
+	return errorResponseBody
+}
+
 func (d *SampleDatasource) CallResource(ctx context.Context, req *backend.CallResourceRequest, sender backend.CallResourceResponseSender) error {
 	var response = &backend.CallResourceResponse{
 		Status:  http.StatusNotFound,
@@ -354,25 +370,32 @@ func (d *SampleDatasource) CallResource(ctx context.Context, req *backend.CallRe
 		discoveryResponse, err = callDiscoveryEndpoint(ctx, d.httpClient, *discoveryServiceUrl)
 		if err != nil {
 			errorMessage := "Unable to obtain ESP server schema information."
-			response.Body = []byte(errorMessage)
+			response.Body = newSerializedCallResourceResponseErrorBody(errorMessage)
 			response.Status = http.StatusInternalServerError
 			log.DefaultLogger.Error(errorMessage, "error", err)
 			return sender.Send(response)
 		}
 
-		responseBody, err := io.ReadAll(discoveryResponse.Body)
+		servers, err := io.ReadAll(discoveryResponse.Body)
 		if err != nil {
 			errorMessage := "Unable to read discovery response."
-			response.Body = []byte(errorMessage)
+			response.Body = newSerializedCallResourceResponseErrorBody(errorMessage)
+			response.Status = http.StatusInternalServerError
+			log.DefaultLogger.Error(errorMessage, "error", err)
+			return sender.Send(response)
+		}
+
+		responseBody, err := json.Marshal(callResourceResponseBody{Data: servers})
+		if err != nil {
+			errorMessage := "Unable to serialize discovery response."
+			response.Body = newSerializedCallResourceResponseErrorBody(errorMessage)
 			response.Status = http.StatusInternalServerError
 			log.DefaultLogger.Error(errorMessage, "error", err)
 			return sender.Send(response)
 		}
 
 		response.Status = http.StatusOK
 		response.Body = responseBody
-		response.Headers["Content-Encoding"] = []string{discoveryResponse.Header.Get("Content-Encoding")}
-		response.Headers["Content-Type"] = []string{discoveryResponse.Header.Get("Content-Type")}
 	default:
 		break
 	}

diff --git a/src/components/QueryEditor.tsx b/src/components/QueryEditor.tsx
@@ -22,6 +22,10 @@ import {
 
 type Props = QueryEditorProps<DataSource, EspQuery, EspDataSourceOptions>;
 
+interface ServersResponse {
+  data: Server[]
+}
+
 interface State {
   isServerDataFetched: boolean;
   serverOptions: Array<SelectableEspObject<Server>>;
@@ -63,16 +67,17 @@ export class QueryEditor extends PureComponent<Props> {
   componentDidMount() {
     this.props.datasource
       .getResource('servers')
-      .then(async (serversResponse: Server[]) => {
-        const [server, project, cq, window, fields] = QueryEditor.deriveSelectionsFromQuery(serversResponse, this.props.query);
+      .then(async (serversResponse: ServersResponse) => {
+        const servers = serversResponse.data
+        const [server, project, cq, window, fields] = QueryEditor.deriveSelectionsFromQuery(servers, this.props.query);
         await this.setStateWithPromise({
           selectedServer: server,
           selectedProject: project,
           selectedCq: cq,
           selectedWindow: window,
           selectedFields: fields
         });
-        await this.updateServers(serversResponse);
+        await this.updateServers(servers);
         await this.setStateWithPromise({ isServerDataFetched: true });
       })
       .catch(console.error);