Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASID - Import lookup table custom step - Initial pull request #193

Closed
wants to merge 11 commits into from

Conversation

sbxchv
Copy link

@sbxchv sbxchv commented Dec 30, 2024

Please include answers to these questions as part of your pull request

In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

  • Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).
    • Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
    • No
  • Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.
    • My contribution does NOT include PII data
    • My contribution includes PII data
  • Q3: Confirm your contribution does not include any encryption or other export-controlled technology.
    • My contribution does NOT contain encryption or other export-controlled technology
    • My contribution includes encryption or other export-controlled technology

ContributorAgreement.txt

Initial commit for SASIS - Import lookup table custom step.
DCO Remediation Commit for sbxchv <[email protected]>

I, sbxchv <[email protected]>, hereby add my Signed-off-by to this commit: ddea781
I, sbxchv <[email protected]>, hereby add my Signed-off-by to this commit: 5bdaf9f
I, sbxchv <[email protected]>, hereby add my Signed-off-by to this commit: 803f4fc
I, sbxchv <[email protected]>, hereby add my Signed-off-by to this commit: 346adbf
I, sbxchv <[email protected]>, hereby add my Signed-off-by to this commit: d6d50b0

Signed-off-by: sbxchv <[email protected]>
Signed-off-by: sbxchv <[email protected]>
Signed-off-by: sbxchv <[email protected]>
Signed-off-by: sbxchv <[email protected]>
Signed-off-by: sbxchv <[email protected]>
@sbxchv
Copy link
Author

sbxchv commented Dec 31, 2024

Pull request for 3 new custom steps :

  • SASID - Import lookup table
  • Serialize into DataGrid
  • SASAPI - GET Metadata

@snlwih
Copy link
Collaborator

snlwih commented Jan 2, 2025

Hi @sbxchv , thank you for this contribution.

Would you mind splitting this into 3 separate pull requests? This allows for much easier and more efficient review process. You can do this by creating 3 branches in your forked repository, one for each of your custom steps. Then issue a pull request from each branch. This will then result in 3 separate pull requests. Thanks in advance.

@sbxchv sbxchv closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants