fix: (IAC-1072) Add AKS pod cidr to LOADBALANCER_SOURCE_RANGES #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
approved these changes
Oct 11, 2023
thpang
approved these changes
Oct 11, 2023
| @@ -62,6 +62,16 @@ | |||
| - tfstate.gke_pod_subnet_cidr is defined | |||
| - tfstate.gke_pod_subnet_cidr.value|length > 0 | |||
| - (tfstate.gke_pod_subnet_cidr.value) not in LOADBALANCER_SOURCE_RANGES | |||
| - name: tfstate - Add AKS pod cidr to LOADBALANCER_SOURCE_RANGES # noqa: name[casing] | |||
| set_fact: | |||
| LOADBALANCER_SOURCE_RANGES: "{{ LOADBALANCER_SOURCE_RANGES + [tfstate.aks_pod_cidr.value] }}" | |||
There was a problem hiding this comment.
Now we have a section for GKE and AWS. This again should be cluster_pod_subnet_cidr in the future and on line 50 above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To enable the North-South traffic again in Azure, a task was added to include
aks_pod_cidrinLOADBALANCER_SOURCE_RANGES.For more details on this change see description of Azure PR #341.
Tests:
Verified following scenarios, for details see internal ticket:
aks_pod_cidris read from tfstate file and added toLOADBALANCER_SOURCE_RANGES. Viya4 deployment stabilized, applications were accessible and the example proc http to query an endpoint was successfulaks_pod_cidrwas added toLOADBALANCER_SOURCE_RANGESin ansible-varsaks_pod_cidrwas not read from tfstate file.LOADBALANCER_SOURCE_RANGESwere set correctly. Viya4 deployment stabilized, applications were accessible and the example proc http to query an endpoint was successful