feat: (PSKD-1006) Use ingress-nginx v1.12 for K8s 1.31 support #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David.Houck <[email protected]>
ephesused
requested changes
Jan 3, 2025
docs/CONFIG-VARS.md
Outdated
| @@ -419,7 +419,7 @@ The EBS CSI driver is currently only used for kubernetes v1.23 or later AWS EKS | |||
| | INGRESS_NGINX_NAMESPACE | NGINX Ingress Helm installation namespace | string | ingress-nginx | false | | baseline | | |||
| | INGRESS_NGINX_CHART_URL | NGINX Ingress Helm chart URL | string | See [this document](https://kubernetes.github.io/ingress-nginx) for more information. | false | | baseline | | |||
| | INGRESS_NGINX_CHART_NAME | NGINX Ingress Helm chart name | string | ingress-nginx | false | | baseline | | |||
| | INGRESS_NGINX_CHART_VERSION | NGINX Ingress Helm chart version | string | "" | false | If left as "" (empty string), version `4.11.1` is used for Kubernetes clusters whose version is >= 1.26.X, and for Kubernetes clusters whose version is <= 1.25.X please set this variable to avoid errors. See [Supported Versions table](https://github.com/kubernetes/ingress-nginx/?tab=readme-ov-file#supported-versions-table) for the supported versions list. | baseline | | |||
| | INGRESS_NGINX_CHART_VERSION | NGINX Ingress Helm chart version | string | "" | false | If left as "" (empty string), version `4.12.0` is used for Kubernetes clusters whose version is >= 1.26.X, for Kubernetes clusters whose version is <= 1.25.X you must set this variable to avoid errors. See [Supported Versions table](https://github.com/kubernetes/ingress-nginx/?tab=readme-ov-file#supported-versions-table) for the supported versions list. | baseline | | |||
There was a problem hiding this comment.
I believe the k8s cluster version warning needs to be adjusted. ingress-nginx 1.12.0 is documented to support k8s 1.28 to 1.32.
There was a problem hiding this comment.
Thanks @ephesused, I also needed to update the k8sMinorVersion value for the new ingress-nginx version so that v1.12.0 will only be installed by default for k8s 1.28 and newer clusters. The output message and behavior should indicate that for K8s clusters <= v1.27, the INGRESS_NGINX_CHART_VERSION var must be explicitly set.
There was a problem hiding this comment.
@ephesused , ready for re-review when you get a chance.
Signed-off-by: David.Houck <[email protected]>
saschjmil
approved these changes
Jan 7, 2025
iadomi
approved these changes
Jan 7, 2025
ephesused
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ingress-nginxHelm chart to use v4.12.0 for K8s >= v1.28 in order to support K8s 1.31INGRESS_NGINX_CHART_VERSIONin CONFIG-VARS.md file to be 4.12.0Tests