Production changes #598
Merged
Production changes #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceelias
approved these changes
Dec 21, 2023
gsmith-sas
requested changes
Dec 22, 2023
There was a problem hiding this comment.
I found one typo and a number of other things that need to be tweaked in the usage output. I was able to add a comment for most of them in-line but for some I could not.
Here is information about those:
- In the usage information, please remove the line starting with "Additional arguments..." since that is not the complete list of fields.
- It appears that the ID field is always included in the output. Therefore, it should be included in the list of default fields AND we should probably mention that the field is always included (as the last column).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes for getlogs - no functionality changes just code style updates