Handle Sass values

[xzyfer]

Currently we coerce all values into quoted Sass Strings.

This PR coerces the JSON value into the appropriate Sass value type.
If the value type cannot be determined we fallback to a quoted
Sass String to avoid errors.

This differs from prior work in that no attempt is made to
mangle JSON arrays and maps into a JSON string value.

Fixes #3

[jonscottclark]

Really nice! Removes the need for any sanitization of inputs after grabbing them from the map. I was relying on sassdash's _.to-number and coercing the result a pixel value.. yuck. This is much better.

Quick test and things look great.

Input:

{
  "color": "#f00",
  "size": "24px",
  "font": "1.5em",
  "darkColor": "darken(#f00, 15%)"
}

@import "config.json";

$color: map-get($config, "color");
$size: map-get($config, "size");
$font: map-get($config, "font");
$darkColor: map-get($config, "darkColor");

body {
  padding: $size + 2px;
  color: lighten($color, 10%);
  font-size: $font * 1.5;
  background-color: $darkColor;
}

Output

body {
  padding: 26px;
  color: #ff3333;
  font-size: 2.25em;
  background-color: #b30000;
}

[jonscottclark]

@xzyfer The only thing I can think that's missing from this is handling booleans.

Input

{
  "bool": false
}

@import "config.json";

$bool: map-get($config, "bool");

body {
  @if $bool {
    padding: 0px;
  } @else {
    padding: 123px;
  }
  &:before {
    content: $bool;
  }
}

Output

body {
  padding: 0px;
}
body:before {
  content: "false";
}

The @if statement is true since it's just being evaluated as a string.

[xzyfer]

Nice suggestions. I think that should be easy enough to do.

…

On Fri., 14 Dec. 2018, 6:54 am Jon Clark ***@***.*** wrote: @xzyfer <https://github.com/xzyfer> The only thing I can think that's missing from this is handling booleans. *Input* { "bool": false } @import "config.json"; $bool: map-get($config, "bool"); body { @if $bool { padding: 0px; } @else { padding: 123px; } &:before { content: $bool; } } *Output* body { padding: 0px; } body:before { content: "false"; } The @if statement is true since it's just being evaluated as a string. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWNi7Cxd-P0xl_6C_uTH3OWuJdj2hks5u4rB8gaJpZM4VcccU> .