Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked BlueprintHookManager to better-prevent hooks from corrupting the code or each other #320

Merged
merged 12 commits into from
Nov 30, 2024
Merged

Reworked BlueprintHookManager to better-prevent hooks from corrupting the code or each other #320

merged 12 commits into from
Nov 30, 2024

Commits on Nov 7, 2024

  1. Reworked BlueprintHookManager to better-prevent hooks from corrupting… 

    … the code or each other.
    @Epp-code
    Epp-code committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5de489d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Addressed first round of code review comments

    @Epp-code
    Epp-code committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    2d37282 View commit details
    Browse the repository at this point in the history

  2. Second round of code review comments.

    @Epp-code
    Epp-code committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    97f9226 View commit details
    Browse the repository at this point in the history

  3. Fixed scenario where hooking function return by exact index AND by EP… 

    …redefinedHookOffset::Return would result in two separate hooks in the map - though they would be called correctly, if a function from the first hook set a return jump, it would skip the functions from the second hook, which would violate the contract that all hook functions at a location are called when a return jump is set.
    @Epp-code
    Epp-code committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    a88eb30 View commit details
    Browse the repository at this point in the history

  4. Added assertion that Function is not null to HookBlueprintFunction to… 

    … fail more clearly in that case
    @Epp-code
    Epp-code committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    93412b0 View commit details
    Browse the repository at this point in the history

  5. Changed additional checkf to fgcheckf so it won't be compiled out

    @Epp-code
    Epp-code committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    190a9a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Removed unnecessary variable redeclaration

    @Epp-code
    Epp-code committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c0631d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Handled EX_SkipOffsetConst in hook manager function to modify offsets

    @Epp-code
    Epp-code committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0e8dc0f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into epp-rework-blueprinthookmanager

    @Epp-code
    Epp-code committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    32bf2e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Addressed review comments. Fixed offset adjustment for Context instru… 

    …ctions and fixed sanity check on ResolvedHookOffset when inserting a hook. Also cleaned up some additional usages of GetNumberField that should have been GetIntegerField.
    @Epp-code
    Epp-code committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    222a5c6 View commit details
    Browse the repository at this point in the history

  2. Actually assert if the requested hook offset is not aligned with a st… 

    …atement.
    @Epp-code
    Epp-code committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    55e717f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Merge branch 'dev' into epp-rework-blueprinthookmanager

    @Epp-code
    Epp-code committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    f62bc4d View commit details
    Browse the repository at this point in the history