Update cordova fingerprint plugin #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace our custom fork with the base version of the cordova-plugin-fingerprint-aio plugin
Removed usages of the clientSecret as it was removed in the latest version of the fingerprint plugin
process.env.PLATFROM was always unset in the cordova code so that the function actually never worked as the condition was never met
andywer
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cordova-plugin-fingerprint-aioplugin by using the base repository instead of our own forkWe don't need our fork anymore as the issue that was the reason why we created the fork in the first place is resolved in v3 of the plugin.
titleanddescriptionvalues to the plugin when showing the authentication dialogThe values are chosen so that it looks like it did before on iOS and only the title is shown on Android.
clientSecretas this is not used in v3 of the plugin anymoreCloses #859 because according to this issue ticket the cause of our crash reports was fixed in the latest version.