Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shiny workshop #378

Merged
merged 10 commits into from
Jun 21, 2022
Merged

Shiny workshop #378

merged 10 commits into from
Jun 21, 2022

Conversation

jnolis
Copy link
Contributor

@jnolis jnolis commented Jun 21, 2022

Materials for the making R Shiny apps Prettier workshop

@jnolis jnolis marked this pull request as ready for review June 21, 2022 15:09
@jnolis jnolis requested a review from jsignell as a code owner June 21, 2022 15:09
@jnolis jnolis requested review from nathanballou and removed request for jsignell June 21, 2022 15:10
@jnolis jnolis requested a review from forana as a code owner June 21, 2022 16:12
nathanballou
nathanballou approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@nathanballou nathanballou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the linting. We need to make sure to remove this from integration tests.

@jnolis jnolis merged commit bde708f into main Jun 21, 2022
@jnolis jnolis deleted the workshop-shiny branch June 21, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell left review comments

@nathanballou nathanballou nathanballou approved these changes

@forana forana Awaiting requested review from forana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnolis @jsignell @nathanballou