Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Update all non-workshop images to latest #387

Merged
merged 10 commits into from
Sep 27, 2022

Conversation

jsignell
Copy link
Contributor

@jsignell jsignell commented Aug 2, 2022

This is a test of the new images, this PR updates all images to new names and latest version.

First batch of integration tests running at https://github.com/saturncloud/release-images/runs/7638367004?check_suite_focus=true

@jsignell
Copy link
Contributor Author

jsignell commented Aug 3, 2022

Take 2 with integration test changes in place: https://github.com/saturncloud/release-images/runs/7653199285?check_suite_focus=true

@jsignell jsignell requested a review from hhuuggoo August 3, 2022 16:02
@jsignell
Copy link
Contributor Author

jsignell commented Aug 3, 2022

There are 2 remaining issue:

  • r-tensorflow, seems like the RETICULATE_PYTHON is pointing to the wrong spot
  • python-rapids: TypeError: C function cuda.ccudart.cudaStreamSynchronize has wrong signature (expected __pyx_t_4cuda_7ccudart_cudaError_t (__pyx_t_4cuda_7ccudart_cudaStream_t), got cudaError_t (cudaStream_t))

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hhuuggoo
Copy link
Collaborator

@jsignell I'm merging this. CI is failing on rf-rapids-dask.ipynb from snowflake, but when I run it, I can't reproduce the failure. I'm merging this so I can get everything on to internal via the template, and then I can track down what's going on. (I'll fix linting first)

@hhuuggoo hhuuggoo marked this pull request as ready for review September 27, 2022 19:41
@hhuuggoo hhuuggoo merged commit d266dab into main Sep 27, 2022
@hhuuggoo hhuuggoo deleted the images-2022.06.01 branch September 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants