This repository has been archived by the owner on Feb 13, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neilk - I took a stab at adding sha256 support to the signature. Interestingly, I didn't need to modify the
set_signature
method at all. Just had to update the special slots on the sha256 CodeDirectory blob and re-hash them. This allowed me to install on iOS 10.Maybe it's my lack of understanding of MachO, but I find this to be really odd. It seems to me that you should need to do something different when creating the CodeDirectory signature, or maybe look for another blob wrapper for the sha256 signature. Perhaps Apple is just not enforcing this at the moment? Or maybe it's my test setup?
Anyway, have a look and let me know what you think.