[sheets] fix splitcell to handle attribute/text pairs #2020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have splitcell account for receiving a list of (attr, text) tuples rather than a list of text lines.
Return a list of (attr, line) for each wrapped line of text. The intent is to have
_splitlines()
play nicely with thedisplayer_generic()
changes here.Open questions:
_splitcell()
will still get a list of strings rather than a list of(attr, text)
pairs?Closes #2019
Unrelated drive-by fix: Looks like we were trying to sum a generator here when counting deferred changes during aNoooope, let #2009 handle that.commit-sheet
command, and that was blowing up vgit tests.