[jsonl] Allow slash comments #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Hey @geekscrapy, thanks for putting this together! If vscode accepts this as a comment, we'll allow it too. BTW for startswith, "prefix can also be a tuple of prefixes to look for", which I'm guessing is faster.
TIL added! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//' to the acceptable comment type for jsonlAlthough not part of the spec, the loader already uses "
#" as a comment. Ironically, vscode does not recognise this as a valid comment delimiter and prefers "//". Therefore I don't think it is a push to include this comment type.