Add codespell config, workflow + have it fixed some typos #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
|
|
Hey @yarikoptic, I'm glad you're enjoying VisiData! @kianmeng submitted a similar PR #1640 which we only took partially, since it unnecessarily changed variable names and the CHANGELOG. This PR seems a bit more tightly scoped, and this fixes all seem like actual misspellings, so I'm inclined to take it. I don't like modifying the CHANGELOG after the fact, but it will be nice to check for future misspellings. I'll let @anjakefala weigh in on making this part of our CI process. |
saulpw
approved these changes
Sep 26, 2023
|
I ran the CI, and it seems fine. I say let's take it for now, and remove it if it becomes frustrating! I am open to trying it out. I like the files you chose to exclude. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using/enjoying
vdso decided to contribute a little thanks ;) Workflow would simply detect when PR is trying to introduce a typo and fail. More about codespell: https://github.com/codespell-project/codespell