Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main-] handle position args as +sheet:subsheet:col:row #2425

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Commits on Nov 28, 2024

  1. [main-] parse +a:b arg as col:row instead of row:col

    Removes unused code that passed wrong type to Path:
    "Path(inputs[-1])"
    midichef committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    85d06f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ea41f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b554020 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd26b71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a08eb3a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6f852a4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c498b22 View commit details
    Browse the repository at this point in the history
  8. [main-] apply +:subsheet:col:row to all sheets

    This handles the case where the sheet is the empty string,
    and a subsheet is specified.
    midichef committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    69ccfb6 View commit details
    Browse the repository at this point in the history
  9. [main-] fail moveToRow if row idx is past the sheet end

    Previously, moveToRow() would return True, and set the cursor
    row index to the nonexistent row, with no visible errors.
    For slow loading sheets, checkCursor() could then move
    the cursor to an earlier row.
    midichef committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f65db0b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    74ccc8b View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. [main-] convert int strings for sheet/subsheet/col/row to ints

    Using int indices internally is better than using sheet names,
    because sheet names were ambiguous when sheets had the same name,
    for example, the name "sample" in:
    vd sample.tsv b.tsv sample.json +1:2
    midichef committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    db6207c View commit details
    Browse the repository at this point in the history