-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main-] handle position args as +sheet:subsheet:col:row #2425
Open
midichef
wants to merge
11
commits into
saulpw:develop
Choose a base branch
from
midichef:start_pos
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 28, 2024
-
[main-] parse +a:b arg as col:row instead of row:col
Removes unused code that passed wrong type to Path: "Path(inputs[-1])"
Configuration menu - View commit details
-
Copy full SHA for 85d06f8 - Browse repository at this point
Copy the full SHA 85d06f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ea41f6 - Browse repository at this point
Copy the full SHA 5ea41f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b554020 - Browse repository at this point
Copy the full SHA b554020View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd26b71 - Browse repository at this point
Copy the full SHA dd26b71View commit details -
Configuration menu - View commit details
-
Copy full SHA for a08eb3a - Browse repository at this point
Copy the full SHA a08eb3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f852a4 - Browse repository at this point
Copy the full SHA 6f852a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c498b22 - Browse repository at this point
Copy the full SHA c498b22View commit details -
[main-] apply +:subsheet:col:row to all sheets
This handles the case where the sheet is the empty string, and a subsheet is specified.
Configuration menu - View commit details
-
Copy full SHA for 69ccfb6 - Browse repository at this point
Copy the full SHA 69ccfb6View commit details -
[main-] fail moveToRow if row idx is past the sheet end
Previously, moveToRow() would return True, and set the cursor row index to the nonexistent row, with no visible errors. For slow loading sheets, checkCursor() could then move the cursor to an earlier row.
Configuration menu - View commit details
-
Copy full SHA for f65db0b - Browse repository at this point
Copy the full SHA f65db0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ccc8b - Browse repository at this point
Copy the full SHA 74ccc8bView commit details
Commits on Dec 1, 2024
-
[main-] convert int strings for sheet/subsheet/col/row to ints
Using int indices internally is better than using sheet names, because sheet names were ambiguous when sheets had the same name, for example, the name "sample" in: vd sample.tsv b.tsv sample.json +1:2
Configuration menu - View commit details
-
Copy full SHA for db6207c - Browse repository at this point
Copy the full SHA db6207cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.