Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FrequencyTable Guide #2534

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Conversation

thejud
Copy link
Contributor

@thejud thejud commented Sep 23, 2024

Per issue #2313 Add a new FrequencyTable guide

For Anja:

  • Add numeric binning

@thejud
Copy link
Contributor Author

thejud commented Sep 29, 2024

I'm working on revisions to this based on the PivotTable feedback. I plan to make it more reference-focused, with examples moved to the end.

@thejud thejud force-pushed the frequency_table_guide branch from bc5c7a1 to 381e202 Compare September 30, 2024 00:40
@anjakefala
Copy link
Collaborator

@thejud Ah okay! Is this ready for review?

@thejud
Copy link
Contributor Author

thejud commented Oct 2, 2024

yes, but happy to revise per any guidance you have. I tried to make some of the changes you made to other documents, condensing, removing some of the expository text, etc...

@anjakefala
Copy link
Collaborator

@thejud and I very much appreciate it <3

thejud and others added 7 commits October 3, 2024 21:20
- it's a bit confusing that the input sheet has `count`
  and the frequency table also has `count`, but they
  refer to different things.
- remove examples, as it is already quite long
- reword many sections to simplify the language
- trim and condense explanatory text
@anjakefala anjakefala force-pushed the frequency_table_guide branch from 0e8456d to 5a2cfcf Compare October 4, 2024 06:09
@thejud
Copy link
Contributor Author

thejud commented Oct 4, 2024

lots of good cleanup. This one was quite challenging!
I thought that some of the usage notes, like extracting unique values, would be very helpful to new users. Also, select first rows is useful for solving other types of problems. Where would it make sense to put usage notes and tips like that? I was thinking that the guides would be a good place to go a bit deeper, and point out some things that might otherwise be missed/forgotten even for non-newbies.

@anjakefala
Copy link
Collaborator

anjakefala commented Oct 5, 2024

Hi @thejud!

I wanted to let you know that even if there are a lot of changes, please do not be discouraged. We are so, so grateful for you figuring out the structure and the bones for these guides. Without the structure you create my edits would not exist. And yes, tackling Frequency Table is especially a challenge.

I thought that some of the usage notes, like extracting unique values, would be very helpful to new users.

It's a conundrum...that was difficult to wrap my head around. I think our original how to guides were this type of content: example workflows. Now that we have the guides, perhaps it makes sense to retire the bulk of the how to guides, and have an indexed page where we collect stuff like this. Let's bring it up in the discord.

I'm not against including them in guides.

@anjakefala anjakefala merged commit acdf5f7 into saulpw:develop Oct 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants