[canvas-] clear box sizes on reset() #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update what is visible after data changes in the source sheet.
anjakefala
force-pushed
the
canvas_reset_boxes
branch
from
5a52aa3 to
ccebd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will help support the use case of monitoring graph sheets by repeatedly reloading them.
Currently, when a graph is reloaded, it won't resize itself to show new datapoints that are outside the current plot view box. After this PR, it will recalculate its size just as if the new data had been present during the first graph draw.
If this PR and #2597 are both accepted, #2570 can be closed.