Use command line git diff --name-only base..head for diff strategy (#…

…57)

* Loop through pages of files to handle more than 300 files

* Remove comment about defaulting to true when > 290 files

* Don't return true if files > 290

* Reimplement diff strategy to handle 300 files better

* Test

* Update dist folder so I can test

* Remove console.logs that were used for debugging

* feat: handle more than 300 files

Fix with git fetch

Co-authored-by: Saurav Aggarwal <[email protected]>

* feat: more than 300 files compared (fix build)

---------

Co-authored-by: Saurav Aggarwal <[email protected]>

package.json

@@ -29,6 +29,7 @@
     "@actions/artifact": "^1.1.1",
     "@actions/core": "^1.10.0",
     "@actions/github": "^5.1.1",
+    "@actions/exec": "^1.1.1",
     "@types/js-yaml": "^4.0.5",
     "adm-zip": "^0.5.10",
     "octokit": "^2.0.19",

src/get-diff-files.ts

@@ -18,8 +18,8 @@ export const getDiffFiles = async (
 ): Promise<ReturnTypeOfDiffFiles> => {
   if (!hash[`${prevSha}--${currSha}`]) {
     hash[`${prevSha}--${currSha}`] = await getFileDiffFromGithub({
-      base: prevSha,
-      head: currSha
+      baseSha: prevSha,
+      headSha: currSha
     })
   }
   return Promise.resolve(hash[`${prevSha}--${currSha}`])

src/github/get-diff-from-commit.ts

@@ -1,8 +1,9 @@
+import * as exec from '@actions/exec'
 import {github} from './client'
 
 type DiffFilesType = {
-  base: string
-  head: string
+  baseSha: string
+  headSha: string
 }
 
 export type ReturnTypeOfDiffFiles = {
@@ -11,18 +12,56 @@ export type ReturnTypeOfDiffFiles = {
 }
 
 export const getFileDiffFromGithub = async ({
-  base,
-  head
+  baseSha,
+  headSha
 }: DiffFilesType): Promise<ReturnTypeOfDiffFiles> => {
-  console.log(`fetching file diff for ${base} ${head}`)
+  const base = await exec.getExecOutput('git' , ['fetch', 'origin', baseSha])
+  const head = await exec.getExecOutput('git' , ['fetch', 'origin', headSha])
+  const diff = await exec.getExecOutput(
+    'git',
+    [
+      'diff',
+      '--name-only',
+      '--ignore-submodules=all',
+      `--diff-filter=ACDMRTUX`,
+      `${baseSha}..${headSha}`
+    ],
+    {
+      cwd: '.',
+      ignoreReturnCode: true,
+      silent: false
+    }
+  )
+
+  if (!diff.exitCode || !base.exitCode || !head.exitCode) {
+    const errors: string[] = []
+
+    if(!diff.exitCode){
+        errors.push( `Failed to get diff files between ${base}..${head} Exit code: ${diff.exitCode}. Due to error ${diff.stderr}`)
+    }
+
+    if(!base.exitCode){
+        errors.push( `Failed to fetch base: ${base} commit Exit code: ${base.exitCode}. Due to error ${base.stderr}`)
+    }
+
+    if(!head.exitCode){
+        errors.push( `Failed to fetch head: ${head} commit Exit code: ${head.exitCode}. Due to error ${head.stderr}`)
+    }
+
+    throw new Error(errors.join("\n"))
+  }
+
+  const allFiles = diff.stdout.split('\n').filter(Boolean)
+
+  // Get the html_url from this only
   const resp = await github.client.rest.repos.compareCommits({
     ...github.getRequestConfig(),
-    base,
-    head
+    base: baseSha,
+    head: headSha
   })
 
   return {
-    files: resp.data.files?.map(item => item.filename) ?? [],
+    files: allFiles,
     url: resp.data.html_url
   }
 }

src/post-comment-on-pr.ts

@@ -24,8 +24,6 @@ const makeSummaryForItem = (item: ArtifactFinalResponseStatus): string => {
   ${item.diffFiles ? '- Diff Files:\n' : ''}
 	${item.diffFiles?.map(file => `\`${file}\``).join('\n') ?? ''}
 </details>
-
-\`Note\`: If Changed Files > \`290\` check will by deafult return true
 `
 }
 

src/regex-match-for-files.ts

@@ -7,9 +7,6 @@ export type ArtifactFinalResponseStatus = ArtifactReponseTypeWithFileDiff & {
 }
 
 export const matchFile = (files: string[], pattern: string): boolean => {
-  if (files.length > 290) {
-    return true
-  }
   const isMatch = picomatch(pattern)
   for (const file of files) {
     if (isMatch(file)) {