chore: update @actions/artifact (#65)

* chore: update @actions/artifact for the purposeof uploading the artifacts sooner

* Remove unnecessary package files

* bug: diff exit code 0 shouldn't fail to return files

* Fix typos in PR comment and documentation files

README.md

@@ -49,7 +49,7 @@ The GitHub token used to authenticate API requests. You can use the `{{ secrets.
 This is the key in which we mention the workflow name and pattern that we want to match which are seperated by `,`.
 
 ### `UPLOAD_KEY` (required)
-This is required when you want to update on successfull run of a job.
+This is required when you want to update the successful run of a job.
 
 ### `DISABLE_CHECK` 
 This is used if you want to disable check then all the keys that are provided will have shouldRun as `true`.

package.json

@@ -26,7 +26,7 @@
   "author": "saurav0705",
   "license": "MIT",
   "dependencies": {
-    "@actions/artifact": "^1.1.1",
+    "@actions/artifact": "^2.1.1",
     "@actions/core": "^1.10.0",
     "@actions/github": "^5.1.1",
     "@actions/exec": "^1.1.1",
@@ -39,7 +39,7 @@
     "@types/adm-zip": "^0.5.0",
     "@types/node": "^18.16.3",
     "@types/picomatch": "^2.3.0",
-    "@typescript-eslint/parser": "^5.59.2",
+    "@typescript-eslint/parser": "^7.0.0",
     "@vercel/ncc": "^0.36.1",
     "eslint": "^8.39.0",
     "eslint-plugin-github": "^4.7.0",

src/artifact.ts

@@ -1,4 +1,4 @@
-import {ArtifactClient, create} from '@actions/artifact'
+import {DefaultArtifactClient} from '@actions/artifact'
 import {
   arrayBufferToFile,
   convertFileToString,
@@ -13,13 +13,9 @@ import {
 import {github} from './github/client'
 
 class ArtifactHandler {
-  client = create()
+  client = new DefaultArtifactClient()
   retentionDays = 30
 
-  setClient(client: ArtifactClient): void {
-    this.client = client
-  }
-
   setRetentionDays(days: number): void {
     this.retentionDays = days
   }

src/github/get-diff-from-commit.ts

@@ -33,18 +33,18 @@ export const getFileDiffFromGithub = async ({
     }
   )
 
-  if (!diff.exitCode || !base.exitCode || !head.exitCode) {
+  if (diff.exitCode || base.exitCode || head.exitCode) {
     const errors: string[] = []
 
-    if(!diff.exitCode){
+    if(diff.exitCode){
         errors.push( `Failed to get diff files between ${base}..${head} Exit code: ${diff.exitCode}. Due to error ${diff.stderr}`)
     }
 
-    if(!base.exitCode){
+    if(base.exitCode){
         errors.push( `Failed to fetch base: ${base} commit Exit code: ${base.exitCode}. Due to error ${base.stderr}`)
     }
 
-    if(!head.exitCode){
+    if(head.exitCode){
         errors.push( `Failed to fetch head: ${head} commit Exit code: ${head.exitCode}. Due to error ${head.stderr}`)
     }
 

src/post-comment-on-pr.ts

@@ -15,7 +15,7 @@ const makeSummaryForItem = (item: ArtifactFinalResponseStatus): string => {
   <summary><h3>${item.suppliedKey}<code>${
     item.shouldRun
   }</code></h3></summary>\n
-  - Last Successfull Run Commit: [${item.sha}](${generateCommitRunUrl(
+  - Last Successfully Run Commit: [${item.sha}](${generateCommitRunUrl(
     item.sha
   )})\n
   - Pattern: \`${item.filesRegex}\`\n