Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom border color prop & option of no remove items selected #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmartinezg
Copy link

@bmartinezg bmartinezg commented Aug 10, 2021

Motivation 😇

On one hand, I faced the problem of can't remove the border-bottom of the main container. On the other hand, i couldn't remove the cross icon of the items selected in the main container.

Actions 💻

To solve the points listed above I added two props to the component:

  • Prop to change the bottom border of the main container, using as default the previous one.
  • Prop of hiding the cross icon when multiple items are selected.

Final result i got:
Captura de pantalla 2021-08-10 a las 14 10 43

Thanks for your attention,

Bruno

@bmartinezg bmartinezg force-pushed the feature/no-remove-items branch from 5b3d583 to 8c2e9c2 Compare August 10, 2021 13:33
@bmartinezg bmartinezg changed the title MR -> Bottom border color prop & option of no remove items selected Bottom border color prop & option of no remove items selected Aug 10, 2021
@sauzy34 sauzy34 self-requested a review August 10, 2021 19:16
@sauzy34 sauzy34 assigned sauzy34 and bmartinezg and unassigned sauzy34 Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants