Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logseq 10.5): Automatic link on pressing enter with Logseq 10.5 #77

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

clarkissac
Copy link
Contributor

Problem

The automatic linking of pages didn't work. The Logseq team probably change the insertBlocks variable to insert-blocks. So the if condition stopped working.

Solution

change the comparison string

@clarkissac
Copy link
Contributor Author

#71

@jotomo
Copy link

jotomo commented Jan 28, 2024

Fix works for me (with 0.10.5) as well.
Would also fix #64.

@Lightup1
Copy link

Thanks a lot. How to easily install this version of the plugin?

@borjarobert
Copy link

Works for me too 🚀

@markscamilleri
Copy link
Contributor

Should this be marked as a breaking change? I haven't tested it on a previous version (so the change might work with older versions). However, looking at the change, it looks like this won't be backwards compatible - and so users still on an older version of logseq will not be able to use the newest version of the plugin.

Otherwise, the condition can be amended to include both strings to make this fix backwards compatible

Copy link

@sharonv sharonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue on win11 v0.10.6

@sawhney17
Copy link
Owner

this looks great, but I think that it would be useful to preserve backwards compatibility by adding an OR check for both of the conditions.

index.ts Outdated Show resolved Hide resolved
@sawhney17 sawhney17 merged commit 42b83f1 into sawhney17:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants