Storeitem #2
Open
Storeitem #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say-paul
reviewed
May 30, 2020
app/store/delete_item.py
Outdated
| @@ -0,0 +1,8 @@ | |||
| from utils import database | |||
| def dltItem(ItemID): | |||
| db=database.Db | |||
There was a problem hiding this comment.
Db is a class, so needs to have ( ), chek user module.
app/store/post_item.py
Outdated
| from utils import database | ||
|
|
||
| def addItem(ItemID,ItemName,ItemUnit,CurrentRate): | ||
| db=database.Db |
app/store/put_item.py
Outdated
| from utils import database | ||
|
|
||
| def updateInfo(ItemID,ItemName,ItemUnit,CurrentRate): | ||
| db= database.Db |
app/store/put_item.py
Outdated
|
|
||
| def updateInfo(ItemID,ItemName,ItemUnit,CurrentRate): | ||
| db= database.Db | ||
| query=("UPDATE ItemRateChart SET ItemName=%s,ItemUnit=%s,CurrentRate=%s WHERE ItemID=%s") |
There was a problem hiding this comment.
What if i want to update a single column?
app/store/put_item.py
Outdated
| def updateInfo(ItemID,ItemName,ItemUnit,CurrentRate): | ||
| db= database.Db | ||
| query=("UPDATE ItemRateChart SET ItemName=%s,ItemUnit=%s,CurrentRate=%s WHERE ItemID=%s") | ||
| params=(ItemName,ItemUnit,CurrentRate) |
There was a problem hiding this comment.
Why params only have 3 value? How to pass the item_id in the where clause?
utils/database.py
Outdated
| print("Error: {}".format(error)) | ||
| return True | ||
| self.mariadb_connection.commit() | ||
| return self.cursor.lastrowid |
There was a problem hiding this comment.
Why return last row ID for delete?
utils/database.py
Outdated
| print("Error: {}".format(error)) | ||
| return True | ||
| self.mariadb_connection.commit() | ||
| return self.cursor.lastrowid |
There was a problem hiding this comment.
Why retrun last row id for update?
|
Add nescerray logging, print statement that can be seen in server, for any reqest sent. Add a util named logging, which will print every requests thet comes to server. Pattern like- GET , POST ....., PUT ... and so on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for insert,update and delete it is showing error about params.
There is no mistake in number and name of parameters in function
for get_item, there is not any error in terminal but error while showing the result