Skip to content

Commit

Permalink
Multiple fixes for dashboards (temporalio#40)
Browse files Browse the repository at this point in the history 
* Replace `type` tag with `service_name`
* Remove obsolete panels
* Set default time range for server dashboards to now-15m
* Use default data source for server general dashboard
* Remove datasource template from visibility + worker dashboards
* Remove cluster/service templating from visibility and worker dashboards
  • Loading branch information
@dnr
dnr authored Dec 7, 2022
1 parent b427de2 commit 590cbf3
Show file tree
Hide file tree
Showing 8 changed files with 223 additions and 547 deletions.
206 changes: 64 additions & 142 deletions misc/advanced-visibility-specific.json
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion misc/clustermonitoring-kubernetes.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@
]
},
"time": {
"from": "now-1h",
"from": "now-15m",
"to": "now"
},
"timepicker": {
Expand Down
46 changes: 23 additions & 23 deletions misc/frontend-service-specific.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@
"steppedLine": false,
"targets": [
{
"expr": "sum (rate(service_requests{type=\"frontend\"}[5m]))",
"expr": "sum (rate(service_requests{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "requests",
"refId": "A"
},
{
"expr": "sum (rate(service_errors{type=\"frontend\"}[5m]))",
"expr": "sum (rate(service_errors{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "errors",
"refId": "B"
Expand Down Expand Up @@ -167,7 +167,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(service_requests{type=\"frontend\"}[5m]))",
"expr": "sum by (operation) (rate(service_requests{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -255,28 +255,28 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(service_errors_entity_not_found{type=\"frontend\"}[5m]))",
"expr": "sum(rate(service_errors_entity_not_found{service_name=\"frontend\"}[5m]))",
"hide": false,
"interval": "",
"legendFormat": "Entity Not Found",
"refId": "A"
},
{
"expr": "sum(rate(service_errors_execution_already_started{type=\"frontend\"}[5m]))",
"expr": "sum(rate(service_errors_execution_already_started{service_name=\"frontend\"}[5m]))",
"hide": false,
"interval": "",
"legendFormat": "Execution Already Started",
"refId": "B"
},
{
"expr": "sum(rate(service_errors_resource_exhausted{type=\"frontend\"}[5m]))",
"expr": "sum(rate(service_errors_resource_exhausted{service_name=\"frontend\"}[5m]))",
"hide": false,
"interval": "",
"legendFormat": "Resource Exhausted",
"refId": "C"
},
{
"expr": "sum by (__name__) (rate({__name__=~\"service_errors_.*\", type=\"frontend\"}[5m]))",
"expr": "sum by (__name__) (rate({__name__=~\"service_errors_.*\", service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "{{ $__name__ }}",
"refId": "D"
Expand Down Expand Up @@ -364,7 +364,7 @@
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(0.95, sum(rate(service_latency_bucket{type=\"frontend\"}[5m])) by (operation, le))",
"expr": "histogram_quantile(0.95, sum(rate(service_latency_bucket{service_name=\"frontend\"}[5m])) by (operation, le))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -466,13 +466,13 @@
"steppedLine": false,
"targets": [
{
"expr": "sum (rate(persistence_requests{type=\"frontend\"}[5m]))",
"expr": "sum (rate(persistence_requests{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "requests",
"refId": "A"
},
{
"expr": "sum (rate(persistence_errors{type=\"frontend\"}[5m]))",
"expr": "sum (rate(persistence_errors{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "errors",
"refId": "B"
Expand Down Expand Up @@ -560,7 +560,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(persistence_requests{type=\"frontend\"}[5m]))",
"expr": "sum by (operation) (rate(persistence_requests{service_name=\"frontend\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -736,7 +736,7 @@
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(0.95, sum(rate(persistence_latency_bucket{type=\"frontend\"}[5m])) by (operation, le))",
"expr": "histogram_quantile(0.95, sum(rate(persistence_latency_bucket{service_name=\"frontend\"}[5m])) by (operation, le))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -838,13 +838,13 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(client_requests{type=\"frontend\", service_role=\"history\"}[5m]))",
"expr": "sum(rate(client_requests{service_name=\"frontend\", service_role=\"history\"}[5m]))",
"interval": "",
"legendFormat": "requests",
"refId": "A"
},
{
"expr": "sum(rate(client_errors{type=\"frontend\", service_role=\"history\"}[5m]))",
"expr": "sum(rate(client_errors{service_name=\"frontend\", service_role=\"history\"}[5m]))",
"interval": "",
"legendFormat": "errors",
"refId": "B"
Expand Down Expand Up @@ -932,7 +932,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(client_requests{type=\"frontend\", service_role=\"history\"}[5m]))",
"expr": "sum by (operation) (rate(client_requests{service_name=\"frontend\", service_role=\"history\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1020,7 +1020,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(client_errors{type=\"frontend\", service_role=\"history\"}[5m]))",
"expr": "sum by (operation) (rate(client_errors{service_name=\"frontend\", service_role=\"history\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1108,7 +1108,7 @@
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(0.95, sum(rate(client_latency_bucket{type=\"frontend\", service_role=\"history\"}[5m])) by (operation, le))",
"expr": "histogram_quantile(0.95, sum(rate(client_latency_bucket{service_name=\"frontend\", service_role=\"history\"}[5m])) by (operation, le))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1210,13 +1210,13 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(client_requests{type=\"frontend\", service_role=\"matching\"}[5m]))",
"expr": "sum(rate(client_requests{service_name=\"frontend\", service_role=\"matching\"}[5m]))",
"interval": "",
"legendFormat": "requests",
"refId": "A"
},
{
"expr": "sum(rate(client_errors{type=\"frontend\", service_role=\"matching\"}[5m]))",
"expr": "sum(rate(client_errors{service_name=\"frontend\", service_role=\"matching\"}[5m]))",
"interval": "",
"legendFormat": "errors",
"refId": "B"
Expand Down Expand Up @@ -1304,7 +1304,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(client_requests{type=\"frontend\", service_role=\"matching\"}[5m]))",
"expr": "sum by (operation) (rate(client_requests{service_name=\"frontend\", service_role=\"matching\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1392,7 +1392,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum by (operation) (rate(client_errors{type=\"frontend\", service_role=\"matching\"}[5m]))",
"expr": "sum by (operation) (rate(client_errors{service_name=\"frontend\", service_role=\"matching\"}[5m]))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1480,7 +1480,7 @@
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(0.95, sum(rate(client_latency_bucket{type=\"frontend\", service_role=\"matching\"}[5m])) by (operation, le))",
"expr": "histogram_quantile(0.95, sum(rate(client_latency_bucket{service_name=\"frontend\", service_role=\"matching\"}[5m])) by (operation, le))",
"interval": "",
"legendFormat": "{{operation}}",
"refId": "A"
Expand Down Expand Up @@ -1560,4 +1560,4 @@
"list": []
},
"version": 3
}
}
Loading

0 comments on commit 590cbf3

Please sign in to comment.