Support non-auto-incrementing models #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 10, 2015 10:11
There are a number of issues related to Laravel not firing model events when using PHPUnit laravel/framework#1181 laravel/framework#4975 This package seems to help with that https://github.com/orchestral/testbench
Without firing the model events (or using a raw insert query) models that don't have an auto-incrementing column won't get a new ID generated and fail at inserting.
Since the default 'getNextModelId' assumes that it's going to be incrementing a number, if a model isn't auto-incrementing (e.g UUID) then they need to override it in a way that works for them.
Ideally this wouldn't be mostly a copy, but a few things need to behave a bit differently (like needing to pass the model_id from the data provider).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for #8
There's a new model 'Foo' that uses UUIDs instead of an auto-incrementing integer column as its primary key. The few changes that need to be made a to make sure that the Laravel model events that a model has set up get fired when being created.
The addition of
orchestra/testbenchis to help with that (without it there's no dispatcher for the models). In theNonIncrementingVersionedTestfile, the events need to be reset every for every test due to what seems like a bug in laravel/framework#1181.The final change in
Versionedis due to the testing and needing to be able to set a fixedmodel_idwhen creating a model that uses UUIDs. If one has been passed in when creating then it doesn't attempt to get a newmodel_id.