Merge adjacent address ranges #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirill-v Thank you for PR and sorry for the delay in reply. I will run some additional tests and get back to you. |
It is required because of the google/nftables#145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for useful library!
When I create L3Rule using the
Listfield of theIPAddrSpecI get error in case of sequential addresses like 1.2.3.32 and 1.2.3.33. I see that inside the library the list is represented like: [{"Key":"1.2.3.32","IntervalEnd":false,"Val":[]},{"Key":"1.2.3.33","IntervalEnd":true,"Val":[]},{"Key":"1.2.3.33","IntervalEnd":false,"Val":[]},{"Key":"1.3.3.34","IntervalEnd":true,"Val":[]}]]. Thenftcommand shows that the corresponding set is not created. So I added code that merges adjacent intervals. But I don't know whether it is a proper solution though. TheRangefield in theIPAddrSpecstructure could be used but it is less convenient.