Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove true east topic #19

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

Tacha-S
Copy link

@Tacha-S Tacha-S commented Mar 14, 2025

support ros2 humble

Summary

  • imu_trueEastを削除(機能としてはyaw_offsetのパラメータで維持)
  • mag_pose2dをdebugのときだけ出すように

Detail

Impact

Test

ros2 run fdilink_ahrs ahrs_driver --ros-args -p port:=/dev/ttyIMU

Attention

@Tacha-S Tacha-S requested a review from a team March 14, 2025 11:41
@jsupratman13
Copy link

@nyxrobotics @gakutasu

imu_trueEastやmag_pose2dトピックはpandaで使っていますか?

@Tacha-S
Copy link
Author

Tacha-S commented Mar 24, 2025

使ってはいないはずですよ
どちらもパラメータを切り替えれば使えるので機能的には残ってますし、
panda ROS 2まだないのでパラメータの設定は任意にできますし問題ないと思いますが...

@nyxrobotics @gakutasu ping

Copy link

@gakutasu gakutasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私としては問題ありません。

@nyxrobotics @jsupratman13
念の為レビューをお願いたします。

Copy link

@nyxrobotics nyxrobotics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更内容良いと思います。
imu_trueEastはおそらく一度も使ったことがないので消して良いと思います。
(PANDAもcuboidもangular velocityとacceleration以外は使ってないと思います。)

@jsupratman13
Copy link

マージタイミングは @nyxrobotics @gakutasu に任せます

@gakutasu gakutasu merged commit 0f43f55 into humble-devel Mar 25, 2025
@gakutasu gakutasu deleted the feature/remove-true-east-topic branch March 25, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants