Farwand refactor #117
Open
Farwand refactor #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wea.farwand was renamed to worldeditadditions_tools, but this reference wasn't updated at the same time. This commit fixes that.
....that is now handled transparently since this is the only call to that function we've hidden it so it isn't exported from weac.pos Finally, mark these functions as internal as they shouldn't be called except internally in pos.lua
|
This is just pending some additional testing to ensure everything works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the big refactor of WEA_Farwand to WEA_Tool. In my bit of testing so far it seems to be stable and working. (I haven't tested the
//farwandcommand at all).