Merge pull request #248 from eatkins/or-filter-fix

Fix bug in converting OrFilter
sbt · Jul 17, 2019 · ee1403f · ee1403f
2 parents 4e19053 + 4035e01
commit ee1403f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/io/src/main/scala/sbt/internal/nio/Globs.scala b/io/src/main/scala/sbt/internal/nio/Globs.scala
@@ -62,7 +62,7 @@ private[sbt] object Globs {
             case (left, Some(NoPath))                        => left
             case (any @ Some(AnyPath), _)                    => any
             case (_, any @ Some(AnyPath))                    => any
-            case (Some(left: Matcher), Some(right: Matcher)) => Some(Matcher.and(left, right))
+            case (Some(left: Matcher), Some(right: Matcher)) => Some(Matcher.or(left, right))
             case _                                           => None
           }
         }

diff --git a/io/src/main/scala/sbt/nio/file/Glob.scala b/io/src/main/scala/sbt/nio/file/Glob.scala
@@ -492,7 +492,7 @@ object RelativeGlob {
      * @return true it the path matches.
      */
     override def matches(path: Path): Boolean = left.matches(path) || right.matches(path)
-    override def toString: String = s"($left && $right)"
+    override def toString: String = s"($left || $right)"
   }
   private[file] final case class AndMatcher(left: Matcher, right: Matcher) extends Matcher {
     override private[sbt] def matchers: List[Matcher] = this :: Nil

diff --git a/io/src/test/scala/sbt/internal/nio/GlobsSpec.scala b/io/src/test/scala/sbt/internal/nio/GlobsSpec.scala
@@ -139,4 +139,12 @@ class GlobsSpec extends FlatSpec {
     assert(!glob.matches(basePath.resolve("foo").resolve("bar.scala")))
     assert(glob.matches(basePath.resolve("foo").resolve("baz.java")))
   }
+  it should "apply or with name filters" in {
+    val excludeFilter: FileFilter = ("Baz.scala": NameFilter) || "Bar.scala"
+    val includeFilter: NameFilter = "*.scala"
+    val filter = includeFilter -- excludeFilter
+    val glob = Globs(basePath, recursive = true, filter)
+    assert(glob.matches(basePath.resolve("foo").resolve("Foo.scala")))
+    assert(!glob.matches(basePath.resolve("foo").resolve("Bar.scala")))
+  }
 }