Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.eclipse.jgit to 6.1.0.202203080745-r #212

Conversation

scala-steward
Copy link
Contributor

Updates org.eclipse.jgit:org.eclipse.jgit from 5.13.0.202109080827-r to 6.1.0.202203080745-r.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.eclipse.jgit", artifactId = "org.eclipse.jgit" } ]

labels: library-update, commit-count:1

Copy link
Collaborator

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this version will increase the required JDK version to 11. I'd be OK with that...

Would need changes to the CI.

@armanbilge
Copy link

armanbilge commented Mar 10, 2022

At least Typelevel is still building/testing/releasing on JDK 8. If our sbt plugins require Java 11 then that forces our project to upgrade.

I suppose with -release flags we could continue targeting JDK 8 from Java 11+, but it would not be easy to test those artifacts on JDK 8. This may or may not be a big deal.

See also:

@raboof
Copy link
Collaborator

raboof commented Mar 10, 2022

I'm fine with postponing this change as well :)

raboof added a commit to raboof/sbt-git that referenced this pull request Mar 11, 2022
Since that requires Java 11 and we're not ready to make that requirement.

Replaces sbt#212
@raboof
Copy link
Collaborator

raboof commented Mar 14, 2022

closing in favor of #214

@raboof raboof closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants