Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 2 fix bug/fix build android #592

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
4 changes: 1 addition & 3 deletions RNAdMobBanner.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import { arrayOf, func, string } from 'prop-types';
import React, { Component } from 'react';
import {
findNodeHandle,
requireNativeComponent,
UIManager,
ViewPropTypes,
requireNativeComponent,
} from 'react-native';
import { createErrorFromErrorData } from './utils';

Expand Down Expand Up @@ -62,7 +61,6 @@ class AdMobBanner extends Component {
AdMobBanner.simulatorId = 'SIMULATOR';

AdMobBanner.propTypes = {
...ViewPropTypes,

/**
* AdMob iOS library banner size constants
Expand Down
4 changes: 1 addition & 3 deletions RNPublisherBanner.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import { arrayOf, func, string } from 'prop-types';
import React, { Component } from 'react';
import {
findNodeHandle,
requireNativeComponent,
UIManager,
ViewPropTypes,
requireNativeComponent,
} from 'react-native';
import { createErrorFromErrorData } from './utils';

Expand Down Expand Up @@ -71,7 +70,6 @@ class PublisherBanner extends Component {
PublisherBanner.simulatorId = 'SIMULATOR';

PublisherBanner.propTypes = {
...ViewPropTypes,

/**
* DFP iOS library banner size constants
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ android {

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'com.google.android.gms:play-services-ads:+'
implementation 'com.google.android.gms:play-services-ads:16.0.0'
}