Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy security rules #58

Merged
merged 1 commit into from
Dec 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"author": "",
"license": "ISC",
"scripts": {
"deploy": "npx firebase-tools deploy --only 'firestore:rules,storage:rules'",
"deploy": "npx firebase-tools deploy --only 'firestore,storage'",
"test": "npx firebase-tools emulators:exec --only 'firestore,storage' 'jest -i'",
"export": "npx firebase-tools emulators:export ./emulator_data",
"lint": "eslint src"
Expand Down
4 changes: 0 additions & 4 deletions firebase/storage.rules
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ service firebase.storage {
return isClubMember(clubId) && request.auth.token.admin == true;
}

function isTableAdmin(clubId, tableId) {
return isClubMember(clubId) && request.auth.token.tableId == tableId;
}

match /clubs/{clubId}/{image} {
function canUpdate() {
return image in ['logo.jpeg'].toSet()
Expand Down
Loading