Wristband distribution #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
approved these changes
Mar 25, 2017
ChaseBro
reviewed
Mar 26, 2017
| elsif building | ||
| @wristband = "Red" | ||
| else | ||
| @wristband = "Blue" |
There was a problem hiding this comment.
Can we please use a reasonable constant here rather than "Red" and "Blue" This new code will already have to change yearly (which sucks), but we should at least have semantically named constants
There was a problem hiding this comment.
Sounds like a good idea to me.
ChaseBro
reviewed
Mar 26, 2017
| @@ -0,0 +1,5 @@ | |||
| class AddBuildingStatusToOrganizationCategory < ActiveRecord::Migration | |||
| def change | |||
| add_column :organization_categories, :building_status, :boolean | |||
There was a problem hiding this comment.
Can this be is_building? More Rails'esque and conveys that it's a boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for issue #220