Extensions list #35
Merged
Extensions list #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carletex
reviewed
Sep 19, 2024
carletex
reviewed
Sep 19, 2024
carletex
reviewed
Sep 19, 2024
carletex
reviewed
Sep 19, 2024
carletex
reviewed
Sep 19, 2024
carletex
reviewed
Sep 19, 2024
There was a problem hiding this comment.
This is looking great (in technical terms**). Just added a couple of nits.
**Maybe we can show it to others before merging (to see if it makes "strategic" sense for everybody). OOOR we could remove the link to it on the Homepage (like a low key launch :D)
Thanks Pablo!
|
Done! Thanks Pablo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm tackling most pending features from #33:
Added a link from the extensions section in the homepage, but could be removed before merging, to confirm that everything (data, click tracking) is working nicely in prod.