Fix: Ensure that Pandas does not treat "None" as NaN #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtauber I think this change is backwards compatible with Pandas 1.x, but I have not done a lot of testing. I did test this out with Python 3.12 and Pandas 1.5.3 and Pandas 2.2.0 as part of writing up scaife-viewer/beyond-translation-site#196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs scaife-viewer/beyond-translation-site@d4efc2a.
The issue was that some English texts had the word
None, which Pandas 2 casts to itsNaNvalue. Then, when we generate SQL statements from Pandas, Pandas tries to insert null values.Read https://pandas.pydata.org/docs/reference/api/pandas.read_csv.html and found
keep_default_na; seemed to work, so if we test that, we can use Pandas 2 instead of 1.