Add code tabs for _tour/compound-types #2552
Conversation
You're right ! Co-authored-by: Jamie Thompson <[email protected]>
There was a problem hiding this comment.
Hello, thank you so much for your work on updating the pages !
I think this page is a bit particular in that aspect, as "compound type" specifically refers to A with B, the name for A & B is an intersection type
Since the title of page explicitly refers to the outdated term, I suggest we change it, for example to "Combining types"
The name of the file should be updated to reflect the change of name. To ensure the old address still works, please use redirect-from (examples)
Co-authored-by: Quentin Bernet <[email protected]>
Co-authored-by: Quentin Bernet <[email protected]>
_tour/intersection-types.md
Outdated
| //... | ||
| } | ||
| ``` | ||
| Compound types can consist of several object types and they may have a single refinement which can be used to narrow the signature of existing object members. |
There was a problem hiding this comment.
This either needs to be dropped, or an example needs to be given
In all cases, we need a user-facing article on what a refinement is (there is none currently)
Especially non-structural refinement
(This is broader than this PR)
_tour/intersection-types.md
Outdated
| //... | ||
| } | ||
| ``` | ||
| Compound types can consist of several object types and they may have a single refinement which can be used to narrow the signature of existing object members. |
|
@flomebul I hope you don't mind me adding some extra commits, but I think changing the content of the article was out of the scope of "add code tabs" so I didn't want to burden that on you |
|
@flomebul thanks again! |
|
added to #2481 |
The linked page has no such example.
No description provided.