Set ACL as public-read for uploads to S3 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline the tiny part of the s3 plugin that we use, since it doesn't provide this extension point. (And our usage of S3 is pretty trivial otherwise.)
|
Tag, @lrytz -- you're it! |
|
LGTM, I'll try it out as soon as I can |
|
I'll also make sure it works. Review was for awareness of the change since you're cutting the next release. |
|
Needed a small tweak, but working now: http://downloads.lightbend.com/scala/2.12.5-bin-ea64efa/scala-2.12.5-bin-ea64efa.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using IAM instance profiles instead of credentials,
our upload is coming from a different account than before
(now: typesafe-scala, before: typesafe-www). This means the
default ACL does not allow access to our uploads, unless
we set it to public-read.
That then set off another chain of events, which resulted in
inlining the tiny part of the s3 plugin that we use, since the plugin
doesn't provide this extension point (see sbt/sbt-s3#37).
(And our usage of S3 is pretty trivial otherwise.)