Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated AnyRefMap #22230

Merged
merged 1 commit into from
Dec 19, 2024
Merged

replace deprecated AnyRefMap #22230

merged 1 commit into from
Dec 19, 2024

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Dec 17, 2024

@xuwei-k xuwei-k marked this pull request as ready for review December 18, 2024 02:41
@Gedochao Gedochao requested a review from mbovel December 19, 2024 09:21
mbovel
mbovel approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces uses of AnyRefMap with HashMap. Both use equals and hashCode to compare values and compute keys. This change therefore preserves the semantic.

@mbovel mbovel merged commit 4b7f321 into scala:main Dec 19, 2024
29 checks passed
@xuwei-k xuwei-k deleted the AnyRefMap branch December 19, 2024 10:01
@WojciechMazur WojciechMazur added this to the 3.6.4 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbovel mbovel mbovel approved these changes

Assignees

@mbovel mbovel

Labels
None yet
Projects
None yet
Milestone
3.6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xuwei-k @mbovel @WojciechMazur