Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise @publicInBinary #22591

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Stabilise @publicInBinary #22591

merged 2 commits into from
Feb 22, 2025

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Feb 12, 2025

Closes #22497

Before merging this PR, the SIP committee still has to vote the acceptance of the SIP.

@hamzaremmal hamzaremmal added the needs-minor-release This PR cannot be merged until the next minor release label Feb 12, 2025
@hamzaremmal hamzaremmal added this to the 3.7.0 milestone Feb 12, 2025
@hamzaremmal hamzaremmal self-assigned this Feb 12, 2025
@hamzaremmal hamzaremmal added the release-notes Should be mentioned in the release notes label Feb 21, 2025
@hamzaremmal
Copy link
Member Author

SIP Committee approved SIP-52

@hamzaremmal hamzaremmal marked this pull request as ready for review February 21, 2025 16:14
@sjrd sjrd disabled auto-merge February 21, 2025 20:42
@sjrd
Copy link
Member

sjrd commented Feb 21, 2025

Disabled auto-merge because we might make this Preview first.

@hamzaremmal
Copy link
Member Author

@sjrd I need it to make progress for the stdlib, we can still open a PR to make it preview next week (as long as it's before the cut-off of 3.7.0).

@sjrd
Copy link
Member

sjrd commented Feb 21, 2025

OK, sure.

@hamzaremmal
Copy link
Member Author

Updated #22638 to reflect what remains to be done

@hamzaremmal hamzaremmal merged commit 4dc4668 into scala:main Feb 22, 2025
27 checks passed
@hamzaremmal hamzaremmal deleted the i22498 branch February 22, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-minor-release This PR cannot be merged until the next minor release release-notes Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilise @publicInBinary in 3.7.0
2 participants