Replace erased class modifiers with Erased base traits #23447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doc pages are now updated to the new scheme. See c878878. |
Since we will force erased expressions to be pure values, they are always initialized.
# Conflicts: # compiler/src/dotty/tools/dotc/ast/TreeInfo.scala
- erasedValue[<ConstantType>] is now considered to be pure - calls of synthetic case class apply are considered pure if the case class is NoInits - Companions of Scala-2 classes Tuple and Some are assumed to be NoInits
Drop the previous convention that Singleton is an erased class under x.modularity. That does not work anynmore if we change to the Erased trait scheme.
Replace with test whether a type derivesFrom Erased.
We should never have flaky tests. Please, everyone adding new tests, watch out for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #23419