Tweak unapply check to fail if type param follows explicit term param #23502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It must be pretty special if I have to look at tests. Edit: extensions may have 2 explicit params. |
som-snytt
force-pushed
the
issue/23499-unapplyish
branch
from
f9983af to
17324cc
Compare
Gedochao
added
the
stat:needs decision
|
We'll discuss this on this week's Scala Core. |
|
I still think this is an abuse of the language, and the pattern should not longer be supported. |
|
After discussing it on today's Scala Core, we decided against this fix. |
Gedochao
removed
the
stat:needs decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23499
Allow the test case, which has no explicit parameter.
With booleans, one has a 50/50 chance of correctness. I'll review this again after a nap.